Skip to content

fix: unnecessary changes to upload-crashlytics-symbols script each time configure project #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

OutdatedGuy
Copy link
Contributor

@OutdatedGuy OutdatedGuy commented Apr 21, 2025

Description

Checks if upload-crashlytics-symbols script exists and only updates the contents shell_script if it exists.

fixes #272

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

@OutdatedGuy
Copy link
Contributor Author

Hi @russellwheatley @SelaseKay, can you review this PR?

@github-actions github-actions bot added the Needs Attention OP created or responded to issue and it needs attention. label Apr 30, 2025
Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OutdatedGuy - thanks, that LGTM 👍

@russellwheatley russellwheatley changed the title fix: unnecessary changes to upload-crashlytics-symbols script fix: unnecessary changes to upload-crashlytics-symbols script each time configure project May 2, 2025
@russellwheatley russellwheatley merged commit c3b1b08 into invertase:main May 2, 2025
6 of 9 checks passed
@OutdatedGuy OutdatedGuy deleted the fix/unnecessary-updates branch May 2, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Attention OP created or responded to issue and it needs attention.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Running flutterfire configure changes values in project.pbxproj each time
2 participants